feat(import-alias):patch change for aliased imported types #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 28, 2024 15:35
Signed-off-by: Jaskeerat Singh Saluja <[email protected]>
Signed-off-by: Jaskeerat Singh Saluja <[email protected]>
Signed-off-by: Jaskeerat Singh Saluja <[email protected]>
Signed-off-by: Jaskeerat Singh Saluja <[email protected]>
|
@mttrbrts @ekarademir Kindly review the PR |
ekarademir
reviewed
Aug 29, 2024
added 2 commits
August 29, 2024 23:09
Signed-off-by: Jaskeerat Singh Saluja <[email protected]>
Signed-off-by: Jaskeerat Singh Saluja <[email protected]>
ekarademir
reviewed
Aug 30, 2024
| @@ -98,7 +98,7 @@ class BaseModelManager { | |||
| // TODO Remove on release of MapType | |||
| // Supports both env var and property based flag | |||
| this.enableMapType = !!options?.enableMapType; | |||
| this.importAliasing = !!options?.importAliasing; | |||
| this.importAliasing = process.env.IMPORT_ALIASING || !!options?.importAliasing; | |||
There was a problem hiding this comment.
Suggested change
| this.importAliasing = process.env.IMPORT_ALIASING || !!options?.importAliasing; | |
| this.importAliasing = process?.env?.IMPORT_ALIASING === 'true' || !!options?.importAliasing; |
Signed-off-by: Jaskeerat Singh Saluja <[email protected]>
ekarademir
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
This pull request deals with analyser rules for aliased types in concerto.
Related Issues
Author Checklist
--signoffoption of git commit.mainfromfork:branchname